xActiveDirectory: Opt-In to DSC Resource Common Meta Tests #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #306 +/- ##
===================================
Coverage 92% 92%
===================================
Files 20 20
Lines 2299 2299
Branches 10 10
===================================
Hits 2135 2135
Misses 154 154
Partials 10 10 |
johlju
reviewed
Jun 1, 2019
There was a problem hiding this comment.
Looking good so far. Are you planning more work in this PR?
Reviewed 3 of 4 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Asking since it is in Draft. 🙂 |
johlju
added
the
waiting for author response
|
Ah, I bet you are waiting for the other PR to be merged. 🙂 |
|
Yes, lets get #303 merged first. |
johlju
added
waiting for code fix
Merge from Dev
johlju
approved these changes
Jun 2, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r6.
Reviewable status:
johlju
removed
the
waiting for code fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR opts the module in to the following DSC Resource Common Meta Tests:
The following files required their Byte Order Mark (BOM) to be removed:
The links in Examples\README.md were converted from root relative to normal relative links. See Links that are relative to root are treated as broken
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is